ANN204 (missing return type for special methods) autofixes#4736
Merged
abravalheri merged 1 commit intopypa:mainfrom Nov 11, 2024
Merged
ANN204 (missing return type for special methods) autofixes#4736abravalheri merged 1 commit intopypa:mainfrom
abravalheri merged 1 commit intopypa:mainfrom
Conversation
8343991 to
8c78ed8
Compare
2 tasks
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Works towards step 6.2 of #2345 (comment)
This will reduce changes from adding return types from typeshed
I commented out
ignore-fully-untypedinruff.tomlthen ranruff check --fix --unsafe-fixes --extend-exclude=setuptools/tests --select=ANN204.Then I removed 3 added return types that were revealing hidden mypy issues to keep the changes here completely automated.
Pull Request Checklist
newsfragments/. (no public facing changes)(See documentation for details)