Remove possibly redundant importlib_machinery code#4097
Merged
Conversation
Avasam
commented
Oct 27, 2023
Avasam
commented
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Prompted by #3979 (comment) and #3979 (comment)
Removing obsolete code and workarounds benefit type-checkers.
The
importlib_machineryalias seems redundant. Maybe a leftover from old code support? If the import failed, all other usages ofimportlib_machinerywould error out anyway. With a less obviousimportlib_machineryrather than the actualImportError.It seems all
importlib.machineryusages we do here (SourceFileLoader,SourcelessFileLoaderandFileFinder) have been added in Python 3.3Pull Request Checklist
newsfragments/.(See documentation for details)