Optional metadata#3289
Optional metadata#3289
Conversation
…uplicates on PyPI). prevent "UNKNOWN" vals from appearing in summary, license, platform. prevent an extra newline getting added in long description
|
Thank you very @wimglenn. Let's see how the discussion in the disutils repository evolves. |
|
Is there any way this change could be applied to Setuptools such that _distutils doesn't have to be altered first? |
|
My interpretation is the following:
|
|
(The last 2 bullet points in the description are fine and not part of the problem with the UX...) |
|
@jaraco I double checked everything and I don't think there is any incompatibility. The setuptools change can go in before the distutils change, and we would not be in a worse place - however the 3rd and the 5th bullet points would remain unfixed (because they need the distutils changes). Bullet points 1, 2, and 4 would be fixed by the setuptools change only. Point 3 is about the warnings from the check command, they look like this: The build still succeeds and makes a valid distribution, they're just bogus warnings. To fix this in setuptools directly without changing distutils you'd have to reimplement the check command, which is the source of the warnings, it currently exists in distutils only. Point 5 is about the "UNKNOWN" strings, these are also coming from distutils. Currently if you omit Summary, License, or Platform you get a PKG-INFO file with lines like this: That's because the "getters" for these fields aren't patched by setuptools, so it goes to distutils Distribution class for them: So, in summary, there is no incompatibility - I tested with |
|
@jaraco ping.. anything more required here? |
|
I'd like to proceed instead with #3299, then confirm tests pass in pypa/distutils#138 and merge that into setuptools. |
Companion to pypa/distutils#138
Project-URL: homepage, https://example.orgintoHome-page: https://example.orgRelated: pypi/warehouse#11220