Change vendoring script to preserve license files#2952
Merged
abravalheri merged 4 commits intopypa:mainfrom Jan 7, 2022
Merged
Change vendoring script to preserve license files#2952abravalheri merged 4 commits intopypa:mainfrom
abravalheri merged 4 commits intopypa:mainfrom
Conversation
As pointed out by pypa#2950, it is probably a good idea to keep the license files for the vendored dependencies. This is done by changing the `pavement.py` tasks.
I believe that only wheels install licenses in the *.dist-info.
Contributor
Author
|
The error in the CI is related to #2921 and not to the changes in the PR. The solution for this problem is being discussed in #2922. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
As pointed out by #2950, it is probably a good idea to keep the license
files for the vendored dependencies.
This is done by changing the
pavement.pytasks:f"{module.basename()}.{license_file.basename()}"Closes #2950 (probably? not sure if legally that is enough)
Pull Request Checklist
changelog.d/.(See documentation for details)