make minimal_egg_info string in bootstrap.py unicode#1063
Closed
mattgiles wants to merge 1 commit intopypa:masterfrom
Closed
make minimal_egg_info string in bootstrap.py unicode#1063mattgiles wants to merge 1 commit intopypa:masterfrom
minimal_egg_info string in bootstrap.py unicode#1063mattgiles wants to merge 1 commit intopypa:masterfrom
Conversation
I believe this is likely to be safe in general, but have only tested with 2.7 on on OS X. Without this change, I am seeing error: ``` $ git clone git@github.com:pypa/setuptools Cloning into 'setuptools'... remote: Counting objects: 24321, done. remote: Compressing objects: 100% (23/23), done. remote: Total 24321 (delta 11), reused 20 (delta 7), pack-reused 24291 Receiving objects: 100% (24321/24321), 28.77 MiB | 7.38 MiB/s, done. Resolving deltas: 100% (8669/8669), done. $ cd setuptools $ git rev-parse HEAD 995d309 $ python bootstrap.py adding minimal entry_points Traceback (most recent call last): File "bootstrap.py", line 63, in <module> __name__ == '__main__' and main() File "bootstrap.py", line 59, in main ensure_egg_info() File "bootstrap.py", line 37, in ensure_egg_info build_egg_info() File "bootstrap.py", line 47, in build_egg_info ep.write(minimal_egg_info) TypeError: must be unicode, not str ```
minimal_egg_info string in bootstrap.py a unicode stringminimal_egg_info string in bootstrap.py unicode
This was referenced Jul 10, 2017
Member
|
Thanks for this, and sorry I left the master in this degraded state. This fix is superseded by dd622e2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is likely to be safe in general, but have only tested with 2.7 on OS X.
Without this change, I am seeing error: