ENH: add multilinux2010#19
Conversation
|
xref pypa/manylinux#179 |
|
I think you opened this before the manylinux2010 image had finished building; that should clear up next time the tests run. You also seem to have a problem running pytest - I think possibly you need the |
|
removed the nose -> pytest changes |
|
This now passes, but the wheels built on the manylinux2010 image appear to get a |
.travis.yml
Outdated
|
|
||
| script: | ||
| - docker run --rm -v `pwd`:/io $DOCKER_IMAGE $PRE_CMD /io/travis/build-wheels.sh | ||
| - docker run --rm -v `pwd`:/io $DOCKER_IMAGE $PRE_CMD -e PLAT=$PLAT /io/travis/build-wheels.sh |
There was a problem hiding this comment.
I think this would have to go before $PRE_CMD.
There was a problem hiding this comment.
right. Sorry, for the noise, I should find a way to test locally before pushing
.travis.yml
Outdated
| services: | ||
| - docker | ||
| env: DOCKER_IMAGE=quay.io/pypa/manylinux2010_x86_64 | ||
| PLAT=manylinux1 |
There was a problem hiding this comment.
2010?
Also, the options for auditwheel need the full platform tag, like manylinux2010_x86_64.
There was a problem hiding this comment.
fixing. What is the 32 bit manylinux1_* full tag?
There was a problem hiding this comment.
trying the docker image name
|
That looks good to me. :-) We could get rid of the DOCKER_IMAGE variable by using |
|
Since this is a demo, I would prefer to be as explicit as possible. Interesting that auditwheel says "INFO:auditwheel.main_repair:Wheel is eligible for a higher priority tag. You requested manylinux2010_x86_64 but I have found this wheel is eligible for manylinux1_x86_64." and then goes and make both wheels, manylinux1 and manylinux2010 |
|
OK, explicit is fine by me. Yes, I think I would have made auditwheel show the message but only add the requested tag, even if another one is valid. What it's doing is reasonable enough, though. |
|
anything else I need to do? |
|
This looks good to me, and I've now been granted the power to merge it 🙂 |
Now that multilinux2010 has been released, update the demo to use it
And as an extra, replace nose with pytestEdit: do not change from nose