Run flake8 static checks separately from test suite#147
Merged
Conversation
Member
Author
|
To be clear, I'm not trying to criticise the developers of pytest-flake8 - I think compatibility headaches are probably unavoidable. Flake8 is pretty clear that it's an application, not a library, and plugin APIs (it's a pytest plugin) are always difficult, because eventually the application developers are going to have a choice between slightly breaking a plugin API and holding back the application development. I'm going to merge this since one of those compatibility issues is currently causing the CI to fail. |
This was referenced Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-flake8 is a compatibility headache - see tholo/pytest-flake8#81 tholo/pytest-flake8#83 & tholo/pytest-flake8#87 . The advantages of running it inside pytest seem small at best, so this gets rid of the pytest integration in favour of running
flake8directly. In the CI, isort & flake8 are run as part of a 'static-checks' job.