Fix: Use sys.executable -m pipenv instead of bare pipenv command#6491
Merged
Fix: Use sys.executable -m pipenv instead of bare pipenv command#6491
Conversation
When running 'python -m pipenv check' in an environment where pipenv is not on $PATH, the check and scan commands would fail because they invoked 'pipenv requirements' as a subprocess using the bare 'pipenv' command. This fix updates get_requirements() in both check.py and scan.py to use [sys.executable, '-m', 'pipenv', 'requirements'] instead of ['pipenv', 'requirements'], ensuring the command works regardless of whether pipenv is on the PATH. Fixes #6042
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
python -m pipenv checkin an environment wherepipenvis not on$PATH, the check and scan commands would fail with:Problem
The
get_requirements()function in bothcheck.pyandscan.pyinvokedpipenv requirementsas a subprocess using the barepipenvcommand:This assumes
pipenvis on the system's$PATH, which may not be true when:python -m pipenvdirectlyFix
Update
get_requirements()to usesys.executableto invoke pipenv as a module:This ensures the command works regardless of whether
pipenvis on the PATH.Files Changed
pipenv/routines/check.py- Updatedget_requirements()functionpipenv/routines/scan.py- Updatedget_requirements()functionFixes #6042
Pull Request opened by Augment Code with guidance from the PR author