Fix: Preserve environment markers when importing requirements.txt#6489
Merged
Fix: Preserve environment markers when importing requirements.txt#6489
Conversation
When using 'pipenv install -r requirements.txt' with packages that have
environment markers (e.g., 'python-magic-bin; sys_platform == "win32"'),
the markers were being ignored and the package was added to Pipfile
without them.
The fix adds marker extraction in generate_package_pipfile_entry() to
include the package.markers attribute in the Pipfile entry when present.
Example: 'python-magic-bin; sys_platform == "win32"' in requirements.txt
now correctly produces:
python-magic-bin = {version = "*", markers = "sys_platform == 'win32'"}
Fixes #6101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
pipenv install -r requirements.txtwith packages that have environment markers (e.g.,python-magic-bin; sys_platform == 'win32'), the markers were being ignored and the package was added to Pipfile without them.Problem
The
generate_package_pipfile_entry()function inpipenv/project.pywasn't extracting themarkersattribute from theInstallRequirementobject when creating the Pipfile entry.Before:
After:
Changes
pipenv/project.py: Added marker extraction in
generate_package_pipfile_entry()to include thepackage.markersattribute in the Pipfile entry when present.tests/integration/test_import_requirements.py: Added a test to verify that environment markers are preserved when importing from requirements.txt.
Test
Fixes #6101
Pull Request opened by Augment Code with guidance from the PR author