Fix: Allow shell builtins to work with pipenv run#6487
Merged
Conversation
Shell builtins (cd, echo, pwd, export, etc.) don't exist as files in the PATH - they're built into the shell itself. Previously, `pipenv run cd` would fail with 'command could not be found' error. The fix modifies do_run_posix to fall back to running commands through the shell when they're not found in PATH, similar to the Windows behavior that already existed in _launch_windows_subprocess. Fixes #6186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shell builtins (cd, echo, pwd, export, etc.) don't exist as files in the PATH - they're built into the shell itself. Previously,
pipenv run cdwould fail with:Changes
Modifies
do_run_posixinpipenv/routines/shell.pyto fall back to running commands through the shell when they're not found in PATH, similar to the Windows behavior that already existed in_launch_windows_subprocess.Before (POSIX)
system_whichAfter (POSIX)
system_whichos.execvefor direct execution (unchanged)subprocess.runwithshell=True(allows shell builtins to work)Testing
test_run_shell_builtinsthat testsecho,pwd, andcdbuiltinspipenv run echo,pipenv run pwd, andpipenv run cdnow work correctlyFixes #6186
Pull Request opened by Augment Code with guidance from the PR author