Merged
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
di
reviewed
Apr 7, 2025
di
approved these changes
Apr 7, 2025
Signed-off-by: William Woodruff <william@trailofbits.com>
This was referenced Apr 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.Some scattered thoughts:
--lockedflag to enable lockfile collection. Does this make sense? Should it happen by default instead, taking priority overpyproject.tomlwhen present?pylock.*.tomlfiles by default, not just the generic one or a particular service-specific one. Does this make sense? Should--lockedtake a value to control this, e.g.--locked=allfor the current behavior and--locked=<service>for justpylock.<service>.toml?This only checksChecked, and[[packages]]. I need to do another closer read of PEP 751 to understand if there are other parts of the file we should collect from.packagesshould be the only part.This doesn't perform any deduplication at the moment, i.e.This is moot, since deduplication is done at the audit layer.foo==1.2.3will be audited multiple times if specified in multiple lockfiles or multiple times in the same file (which the PEP allows). This probably won't happen often but I should probably add that deduplication, similarly to howrequirements.txtinputs are handled.Signed-off-by: William Woodruff william@trailofbits.com