Skip to content

Adding --osv-url argument to allow use of private OSV vulnerability services#810

Merged
woodruffw merged 3 commits intopypa:mainfrom
davidjmemmett:issue_805__support_for_private_osv_repositories
Apr 8, 2025
Merged

Adding --osv-url argument to allow use of private OSV vulnerability services#810
woodruffw merged 3 commits intopypa:mainfrom
davidjmemmett:issue_805__support_for_private_osv_repositories

Conversation

@davidjmemmett
Copy link
Copy Markdown
Contributor

@davidjmemmett davidjmemmett commented Aug 8, 2024 •
edited by woodruffw
Loading

See #805 for more details.

Closes #805.

@davidjmemmett davidjmemmett mentioned this pull request Aug 8, 2024
Closed
3 tasks
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Aug 9, 2024

Thanks @davidjmemmett! I'll try and set aside some time for review on this in the coming days.

@davidjmemmett
Copy link
Copy Markdown
Contributor Author

davidjmemmett commented Aug 29, 2024

Thank you @woodruffw

@davidjmemmett davidjmemmett force-pushed the issue_805__support_for_private_osv_repositories branch from e2936c5 to ea3c1b1 Compare September 8, 2024 10:35
@davidjmemmett
Copy link
Copy Markdown
Contributor Author

davidjmemmett commented Sep 8, 2024

Is there anything further required to get this over the line @woodruffw?

@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Sep 9, 2024

Is there anything further required to get this over the line @woodruffw?

Just my review time, sorry 🙂 -- I'll try and set aside some cycles in the coming days.

@woodruffw woodruffw mentioned this pull request Apr 8, 2025
Open
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Apr 8, 2025

Hey @davidjmemmett, apologies for the very slow cycle on this -- I took a look just now, and your approach looks good to me! I'm going to do some local testing now as well.

@woodruffw woodruffw force-pushed the issue_805__support_for_private_osv_repositories branch from aadb00b to 9b8376b Compare April 8, 2025 14:57
@woodruffw woodruffw added component:cli CLI components component:vuln-sources Components that provide sources of vulnerability information enhancement New feature or request labels Apr 8, 2025
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Apr 8, 2025

Thanks @davidjmemmett!

@woodruffw woodruffw merged commit 897c630 into pypa:main Apr 8, 2025
10 checks passed
@davidjmemmett
Copy link
Copy Markdown
Contributor Author

davidjmemmett commented Apr 8, 2025

Thank you for merging, much appreciated!

@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Apr 8, 2025

No problem, thanks for bearing with me! LMK if you'd like this in a release sooner rather than later; otherwise, it'll probably go out whenever I do v2.10.0, which might be a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

component:cli CLI components component:vuln-sources Components that provide sources of vulnerability information enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: stable API to add additional VulnerabilityService instances for private repositories

2 participants

@davidjmemmett @woodruffw