Fix tempfiles on windows, fixes #646#647
Merged
Conversation
woodruffw
reviewed
Jul 11, 2023
Member
woodruffw
left a comment
There was a problem hiding this comment.
Sorry for the delay here; a couple of thoughts!
woodruffw
reviewed
Jul 13, 2023
woodruffw
reviewed
Jul 13, 2023
Contributor
Author
|
sorry about that, hastely comitted without running pylint. |
woodruffw
approved these changes
Jul 24, 2023
Member
woodruffw
left a comment
There was a problem hiding this comment.
LGTM, thank you @marickmanrho!
Signed-off-by: William Woodruff <william@trailofbits.com>
Member
|
This is included in 2.6.1, which is in the process of being released now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes pip-audit on Windows machines by providing a work around for
NamedTempFile. This workaround is implemented in the_util.pyfile asCustomNamedTempFile.The
CustomNamedTempFilecreates a temporary file as expected but allows the file to be open and closed multiple times.CustomNamedTempFilealso works as a contextmanager and closes+removes the file when exiting the context.