Revise lazy wheel and its tests#8584
Conversation
|
CI hasn't triggered for this PR for some reason. Huh. |
|
That should help? |
|
I've just pushed a new commit and the CIs are getting the hook now. I've been spending so much time on this so I guess I'll switch back to implementing the integration of the utilities. This is wearing me out and being stressed about not getting things done makes me even less productive 😄 The part I'm particularly stuck at is (I think, regarding the error log) how to provide the response for HEAD requests and probably the mock server doesn't handle multiple requests: 7df1646. Mainly because I couldn't found the part of tutorial referring to what pip is doing currently. |
I think we should do that in an follow up PR - this change as is is pretty atomic and does one thing (which makes it easier to review, discuss etc). |
|
I'm happy to reset to da574fb and revisit the mock server supporting range request thing when I'm emotionally recovered from this and/or these tests show to have too much negative effect on the whole suit. I also figure that it's not likely that we should mock a server with all the dependencies for the integration tests. |
7df1646 to
892018e
Compare
|
@pradyunsg, is there anything you'd like to iterate on before merging? |
Nope -- LGTM. |
This PR aims to do two things
At the moment I haven't quite figured out how to use pallets/werkzeug#978 as suggested by @chrahunt in #8532 (comment).