Report files in original (filesystem) case#5642
Conversation
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM.
Flake8 doesn't seem happy about the conditional. Maybe move out the condition into parentheses and a variable?
|
@pradyunsg Yeah flake8 is a whiny little nuisance. I'm fixing it now. |
|
Fixed it by making the code look uglier :-( |
| file_ = os.path.normcase(os.path.join(dirpath, fname)) | ||
| if os.path.isfile(file_) and file_ not in files: | ||
| file_ = os.path.join(dirpath, fname) | ||
| if (os.path.isfile(file_) and |
There was a problem hiding this comment.
How about making a should_skip variable here? That way the conditional can be more readable. :)
There was a problem hiding this comment.
Assigning a should_skip variable would still have to go across two lines, so no real readability improvement. TBH, I can't be bothered - this is a case where arguing about readbility improvements is non-productive IMO, so I'd rather just leave it.
At the root, I just disagree with flake8's rule here, so closing my eyes and doing something that conforms to the rule is sufficient for me.
There was a problem hiding this comment.
Cool. I don't think it's super important anyway. :P
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
PR based on #4770 (comment)