Skip to content

Add missing entries for un-vendored support#4661

Merged
pradyunsg merged 1 commit into
pypa:masterfrom
benoit-pierre:fix_un-vendored_support
Oct 7, 2017
Merged

Add missing entries for un-vendored support#4661
pradyunsg merged 1 commit into
pypa:masterfrom
benoit-pierre:fix_un-vendored_support

Conversation

@benoit-pierre

Copy link
Copy Markdown
Member

Fix #4660.

@benoit-pierre

Copy link
Copy Markdown
Member Author

I've no idea why the un-vendored py36 job is failing, since there should be no difference with the py36 job...

I've put the usual stuck pypy job out of its misery.

@pradyunsg pradyunsg added the type: enhancement Improvements to functionality label Aug 9, 2017
@pradyunsg

Copy link
Copy Markdown
Member

So, IIRC, pip doesn't support running unvendored. It's just that it's a use case that we try to not break unintentionally. The news fragment would need to change and be a little clear about that. :)

@benoit-pierre

benoit-pierre commented Aug 9, 2017

Copy link
Copy Markdown
Member Author

OK, I was not sure if a NEWS entry is even needed, as I think it's just un-breaking unreleased code, and NEWS only list changes between 2 official releases, no?

@pradyunsg

pradyunsg commented Aug 9, 2017 via email

Copy link
Copy Markdown
Member

@benoit-pierre benoit-pierre force-pushed the fix_un-vendored_support branch from c5eeb37 to 04a5119 Compare August 10, 2017 14:24
@benoit-pierre

Copy link
Copy Markdown
Member Author

Rebased on master and removed the NEWS entry.

@pradyunsg pradyunsg added C: automation Automated checks, CI etc skip news Does not need a NEWS file entry (eg: trivial changes) labels Aug 10, 2017
@pradyunsg pradyunsg removed the C: automation Automated checks, CI etc label Aug 18, 2017
@BrownTruck

Copy link
Copy Markdown
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 31, 2017
@pradyunsg pradyunsg changed the title fix un-vendored support; add missing entries Add missing entries for un-vendored support Sep 1, 2017
@benoit-pierre benoit-pierre force-pushed the fix_un-vendored_support branch from 04a5119 to d1e1c05 Compare September 1, 2017 12:35
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Sep 1, 2017
@benoit-pierre

Copy link
Copy Markdown
Member Author

Rebased.

@pradyunsg

Copy link
Copy Markdown
Member

Merging because the cost of getting it wrong is not too high. :)

@pradyunsg pradyunsg merged commit d8e6654 into pypa:master Oct 7, 2017
@benoit-pierre benoit-pierre deleted the fix_un-vendored_support branch October 26, 2017 13:10
@lock

lock Bot commented Jun 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: enhancement Improvements to functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip un-vendored support is broken

4 participants