Closed
Conversation
Contributor
Author
|
Apologies for the monstrous commit, but most of the changes were very intertwined. This pull request can be considered a precursor to the improved option handling that is described in pull request 428. |
pip/baseparser.py
Outdated
Contributor
There was a problem hiding this comment.
man? AFAIK there is no man page support for pip.
It is an open issue indeed: #415
Contributor
Author
There was a problem hiding this comment.
Correct. This is a remnant of pull request 428. I'll remove it.
Contributor
Author
Contributor
|
Needs reworking to cleanly apply as I've merged 464. |
Contributor
Author
|
Can we get #465 in first? I'll rebase with |
Contributor
|
Have done 465, look forward to the next round of review/testing. |
* Remove module-singleton baseparser.parser object. A parser instance is created in pip.main() and passed as the first argument to each command. Each command can access the main parser from self.main_parser. * Remove all global command instances. Commands are instantiated on demand in pip.main(). Deferred command module imports were removed. * Factor option handling out of pip.main() and into pip.parseopts() * The list of available commands is now part of the parser's description and comes before all other options. 'Pip help' is more targeted at showing the options of a command instead of all available commands. * Move command specific options under a 'Command Options' OptionGroup * Move general options under a 'General Options' OptionGroup Conflicts: pip/__init__.py
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework pip command handling
created in pip.main() and passed as the first argument to each command. Each
command can access the main parser from self.main_parser.
pip.main(). Deferred command module imports were removed.
comes before all other options. 'Pip help' is more targeted at showing the
options of a command instead of all available commands.
This pull request depends on pull requests 464 465 466