Add tests for shortened 'pip uninstall' output#4502
Merged
dstufft merged 7 commits intopypa:masterfrom Jun 14, 2017
Merged
Conversation
Member
|
A few unit-tests should be good :) |
Member
Author
|
@xavfernandez I hope you don't mind that I also changed the test_download.py file. If you think it's not nice to be modifying that file here, I'll undo that and make a new PR for that. But I almost feel that'll be overkill. |
Member
Author
|
Oh, and unless something interesting happens on Travis, I think this is done. /request-review @xavfernandez @dstufft @pfmoore |
xavfernandez
approved these changes
Jun 5, 2017
Member
There was a problem hiding this comment.
sample = [path for path in sample if ".skip." not in path] seems simpler
Member
There was a problem hiding this comment.
This docstring is quite hard to parse
Member
Author
|
@xavfernandez I hope that addresses your comments. :) |
c7e493b to
93372db
Compare
93372db to
72b91cc
Compare
Member
Author
|
Is there anything outstanding? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #4493.
@xavfernandez Do you think the tests should be unit tests or functional tests? (I'm thinking unit but confirming).