Allow unpinned requirements to use hashes from constraints#13887
Open
Allow unpinned requirements to use hashes from constraints#13887
Conversation
5ce88cb to
dac19f2
Compare
pradyunsg
commented
Apr 6, 2026
Comment on lines
+60
to
+63
| hash_options = { | ||
| alg: [v for v in other.hash_options[alg] if v in self.hash_options[alg]] | ||
| for alg in self.hash_options.keys() & other.hash_options.keys() | ||
| } |
Member
Author
There was a problem hiding this comment.
Should multiple entries for the same requirement get unioned or intersected?
Right now, this mirrors Hashes.__and__: uses as-is when one side is empty, intersection of them when both are present.
Member
There was a problem hiding this comment.
Though choice. Maybe unioned in case users combine constraints files for different platforms?
Constraints with `==version --hash=...` correctly narrow the candidate set, but the per-candidate `InstallRequirement` still reflected the original unpinned and hashless requirement. In such a configuration, plumb through the hashes from the constraints to the per-candidate `InstallRequirement`, and pin it to the version from the link (which is informed by the constraint). This makes hashes get correctly used for candidate selection and verification, at the cost of a few copies at the start of the resolve in such cases.
dac19f2 to
3cd1be1
Compare
sbidoul
reviewed
Apr 11, 2026
Comment on lines
+60
to
+63
| hash_options = { | ||
| alg: [v for v in other.hash_options[alg] if v in self.hash_options[alg]] | ||
| for alg in self.hash_options.keys() & other.hash_options.keys() | ||
| } |
Member
There was a problem hiding this comment.
Though choice. Maybe unioned in case users combine constraints files for different platforms?
| template = copy.copy(template) | ||
| template.hash_options = { | ||
| k: list(v) for k, v in constraint_hash_options.items() | ||
| } |
Member
Author
There was a problem hiding this comment.
Yea, I could do a deepcopy directly too; if that'd be clearer. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9243, I think?
This is now a tomorrow thing for me. Gotta go to PyCon US stuff now.