Stop collecting links for non-working deduping - Reduce peak memory by 50% during long resolves#13843
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12834
_logged_linksstored(Link, LinkType, str)tuples to deduplicate "Skipping link" debug messages. Because eachLinkhashes by URL, every entry was unique the dedupe never fired, the set just accumulated Link references, preventing GC of anything the Link object was referencing.As this never worked I'm just removing it, keeping only a
set[str]for Requires-Python skip reasons (the only data read back from the set).Using the following large resolve as a test:
~120k Link objects were not stored in the set, and peak memory went down from ~350 MiB to ~180 MiB.