Add rstrip in def _strip_extras#13523
Merged
Merged
Conversation
Member
|
Hi @mtsokol thanks for your PR to pip, please be aware it may take a bit for a maintainer to review as we are all doing this on a volunteer basis. |
ichard26
approved these changes
Aug 14, 2025
ichard26
left a comment
Member
There was a problem hiding this comment.
This will also permit -e "file:///path/to/project [extra]" but that doesn't carry over to a regular install. (Editable requirements are parsed using a different code path.) I think this is fine though as folks should be using the Direct URL syntax if they're looking to request an extra, anyway.
Co-authored-by: Richard Si <sichard26@gmail.com>
Contributor
Author
|
@ichard26 Thanks! I included your suggestion. |
notatallshaw
approved these changes
Sep 11, 2025
notatallshaw
left a comment
Member
There was a problem hiding this comment.
Thanks @mtsokol for your contribution to pip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All,
Installing from
.whlfile with extras, where there's a whitespace between filename and extras section is broken:which is caused by untrimmed file extension:
.whlinstead of.whl.This PR fixes it by striping path when separating from extras section, with a test that fails for the current
main.