list: disable pip version self check unless given --outdated/--uptodate#12646
Merged
Conversation
Member
Author
|
@sbidoul I know that you took issue with my previous approach, let me know if this is more palatable :) |
uranusjr
approved these changes
Apr 23, 2024
Member
Author
|
Thanks @uranusjr for the review and @pradyunsg for accepting my change for the release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11677.
Writing the test here was a painful experience as I didn't realize that the
PIP_DISABLE_PIP_VERSION_CHECKenvironment variable was being set by default.