Remove --no-binary disabling wheel cache#11872
Conversation
--no-binary disabling wheel cache sbi--no-binary disabling wheel cache sbi
--no-binary disabling wheel cache sbi--no-binary disabling wheel cache
a1ab613 to
a266f3d
Compare
a266f3d to
41f9bc9
Compare
41f9bc9 to
c6d74cb
Compare
| "fast-deps", | ||
| "truststore", | ||
| "no-binary-enable-wheel-cache", | ||
| "no-binary-enable-wheel-cache", # now always on |
There was a problem hiding this comment.
Why not remove this, as we've done with other --use-feature flags?
There was a problem hiding this comment.
I kind of remember folks complaining that we remove feature flags that became always on because it was causing unnecessary churn and I was kind of agreeing. But yeah if we keep it we probably need some warning that it's going away one day. Not sure what's best.
There was a problem hiding this comment.
Let's leave it in with a warning -- it's less churn for end users. However, I do feel like we should print these "ignored use-feature" warnings in a single central location, instead of scattering them across the commands. Do that seem reasonable?
If so, the only place that I can think of at the moment is Command._main, and... well, I trust your judgement on determining a good place. :)
There was a problem hiding this comment.
@pradyunsg I have centralized the handling of always enabled features, so it will be easy to use for future similar cases.
I do that immediately after setting up the logger so we get the colored warning.
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM, except for one minor concern.
c6d74cb to
2617ccd
Compare
closes #11453
closes #9162