Skip to content

Run simple Git server for test#11554

Closed
uranusjr wants to merge 2 commits intopypa:mainfrom
uranusjr:replace-git-server-in-tests
Closed

Run simple Git server for test#11554
uranusjr wants to merge 2 commits intopypa:mainfrom
uranusjr:replace-git-server-in-tests

Conversation

@uranusjr
Copy link
Copy Markdown
Member

@uranusjr uranusjr commented Oct 27, 2022

New Git version disallows automatically cloning the file: protocol, so let's use something else. The git:// protocol is the easiest to set up.

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 27, 2022
New Git version disallows automatically cloning the file: protocol, so
let's use something else.
@uranusjr uranusjr force-pushed the replace-git-server-in-tests branch from a98ac43 to d692307 Compare October 27, 2022 15:00
Copy link
Copy Markdown
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted here could we add a news entry, saying something like "Newer git versions no longer allow the file: protocol for submodules. Fix tests to deal with this"?

I assume we don't know why the approaches git suggests for allowing trusted submodules to use file: don't work for us? Is it purely a problem on CI, or does the same issue happen locally?

@uranusjr
Copy link
Copy Markdown
Member Author

uranusjr commented Oct 27, 2022

I have no idea, to be honest. Information on how exactly this should be handled is sparse (the release is so new), espacially on git submodule since git submodules suck to begin with and barely anyone uses it, let along with file:. I can’t make the config work on my own machine either, so this is not specific to CI, but it’s unclear whether I’m missing something, or the git docs lacks critical information.

@pfmoore
Copy link
Copy Markdown
Member

pfmoore commented Oct 27, 2022

OK, so we're safe to say to people hit by this "we don't know how to get file: urls to work either, you'll need to ask in a git support channel". That sounds fair to me.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Oct 27, 2022
@uranusjr uranusjr closed this Oct 27, 2022
@uranusjr uranusjr deleted the replace-git-server-in-tests branch October 27, 2022 17:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants