Closed
Conversation
In itself, this commit does not change pip's behaviour, because the presence of --build-option and --global-option imply --no-binary :all: which in turn disable wheel building.
This was referenced Aug 12, 2022
pradyunsg
reviewed
Aug 13, 2022
Member
pradyunsg
left a comment
There was a problem hiding this comment.
I've skimmed through this, and it seems reasonable overall.
Member
Author
|
So, coming back to this, I realize that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to illustrate the whole path towards disentangling
--no-binary. Please do not do detailed code review here, it will be split in individual PRs for review. Questions and suggestions on the overall approach are most welcome here.This is encapsulates my takeaways from #9778 and #9422.
deprecate
--install-option(Deprecate --install-options #11359)clarify the warning message when
--install-option/--global-option/--build-optionis used, saying that it implies--no-binary=:all:which is accurate, instead ofdisabling all use of wheelwhich was not entirely true in all cases. (also in Deprecate --install-options #11359)add a dreprecation warning when
--no-binaryimplies setup.py installadd a
no-binary-builds-wheelsfeature flag which does the following when--no-binaryis used:setup.py installlet it build and install a wheel (thereby silencing the deprecation warning)pip installandpip wheel(the user can still control it with--no-cache)pass
--build-optionand--global-optionin the build step, likepip wheeldoes - if only for symmetry and to soften the transition; we nevertheless recommend users to use--config-settingsand we'll likely deprecate these in the future, forpip installandpip wheelat the same time.