Update the RECORD entry when rewriting the shebang line in a script#11052
Merged
Update the RECORD entry when rewriting the shebang line in a script#11052
Conversation
4054130 to
e99ea9e
Compare
uranusjr
approved these changes
Apr 21, 2022
Member
uranusjr
left a comment
There was a problem hiding this comment.
Makes sense to me. We should probably switch to installer eventually but this is small enough a change to go in now.
e99ea9e to
b282e58
Compare
Contributor
Author
|
Rebased to fix merge conflicts. There's one test failure now, but I think that's due to a transient network problem. |
Member
|
@SpecLad there was a CI error, likely a transient. Could you rebase again to be sure everything is green ? |
The code to do this already exists in `get_csv_rows_for_installed`, but it's broken due to inconsistent usage of the `_fs_to_record_path` function. When we build the dictionary of installed files, we call it with a base directory, while when build the set of modified files, we call it without a base directory. As a result, the values of `installed` do not match the elements of `changed`, and `get_csv_rows_for_installed` fails to identify the rows that should be updated. Fix this by ensuring that `_fs_to_record_path` is always called with a base directory. `_record_to_fs_path` also needs a a base directory parameter to be able to transform the path back into an absolute path, so add one.
b282e58 to
e4cd6da
Compare
Member
|
The ReadTheDocs job did complete, but reporting on GitHub seems stuck for whatever reason. Admins can still merge though. |
Member
|
Thank you, @SpecLad ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to do this already exists in
get_csv_rows_for_installed, but it's broken due to inconsistent usage of the_fs_to_record_pathfunction. When we build the dictionary of installed files, we call it with a base directory, while when build the set of modified files, we call it without a base directory. As a result, the values ofinstalleddo not match the elements ofchanged, andget_csv_rows_for_installedfails to identify the rows that should be updated.Fix this by ensuring that
_fs_to_record_pathis always called with a base directory._record_to_fs_pathalso needs a a base directory parameter to be able to transform the path back into an absolute path, so add one.Fixes #10744