Smarter (and looser) link equivalency logic#10079
Merged
Conversation
503aeda to
c55d17c
Compare
1 task
b0adb89 to
a889a22
Compare
a889a22 to
a323183
Compare
48fd6a9 to
c53ed18
Compare
c53ed18 to
83d092f
Compare
Member
Author
|
Still hoping someone could take a look. I detailed the logic in the docstring, a brief browse would be much appreciated. |
pfmoore
approved these changes
Jul 12, 2021
Member
pfmoore
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I've only desk-checked, and I've not really reviewed the tests, but the logic seems good.
pradyunsg
approved these changes
Jul 12, 2021
Member
pradyunsg
left a comment
There was a problem hiding this comment.
Implementation LGTM!
A few non-blocker comments on the tests, and one maybe-should-do-later suggestion.
Comment on lines
+1825
to
+1830
| pytest.param( | ||
| False, | ||
| "#subdirectory=bar&egg=foo", | ||
| "#subdirectory=rex", | ||
| id="drop-egg-still-different", | ||
| ), |
Member
There was a problem hiding this comment.
nit-ish: Add another test for the reverse of this, and move this to the top with the other drop- tests?
Member
Author
There was a problem hiding this comment.
Reverse as in reversing subdirectory and egg, or the two values to arguments?
3707bf1 to
c7bec9b
Compare
edmorley
reviewed
Jul 19, 2021
c7bec9b to
2da77e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10002 (eventually).
Todo:
links_equivalent.Add a--use-deprecatedflag to enable the current (stricter) behaviour in case this does not work for some cases.Decided to not do this since I don’t see how users would find this flag useful.
Add a deprecation warning whenegg=is used. (How can we only show this once?)Not doing this for now, see Resolution conflict due to the PEP 508 requirement with superfluous #egg fragment specified in a package’s metadata #10002 (comment)
Dig out previous issues on this and close them (IIRC there are a couple).refactor pip's use of "#egg=" #1289 is the other issue about this, but that one is wider in scope and cannot be closed by this alone.