perf: use map instead of generator #996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another slow line in the profile. This one is the only case in the codebase that I see using a simple generator like this on
.split("."), all the rest usemap. Usingmapsaves about 8% when creatingVersion's. Usingtuple([...])also saves around 8%, but I think the map is nicer than using a list comprehension inside a function call (and also consistent with the other cases, like intags.py).Edit: also found one more place, inside the
__str__method, which is used in SpecifierSet, for example.