perf: avoid duplicate Version creation in canonicalize_version #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80ae4a4 to
2afa041
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
b8b4d5a to
3b4d479
Compare
Contributor
Author
|
FYI, for an overall improvement measure, reading all |
brettcannon
approved these changes
Nov 27, 2025
Contributor
Author
|
FYI, the 3.15 flamegraph is starting to look pretty good for SpecifierSet (and therefore Version) creation. The regex is starting to dominate like it should, and most of the other things are pretty even and getting smallish. Mapping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #993.
This makes
SpecifierSetcreation take 37% less time (on top of the previous 7%) by avoiding extraVersioncreation. It does it by adding a new signature to_TrimmedReleasewith aVersionargument instead of only astr, which does a low-cost cast.There are probably other ways to do this if we don't want to add aActually, I like not changing API at all when working on performance, so I moved this to the subclass.Version(version: Version)signature, starting with this as it's simple to open discussion. We could only support this in the subclass for example.