chore: minor cleanup to regex code #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
brettcannon
approved these changes
Nov 25, 2025
brettcannon
reviewed
Nov 25, 2025
| """ | ||
|
|
||
| _regex = re.compile(r"^\s*" + VERSION_PATTERN + r"\s*$", re.VERBOSE | re.IGNORECASE) | ||
| _regex = re.compile(r"\s*" + VERSION_PATTERN + r"\s*", re.VERBOSE | re.IGNORECASE) |
Member
There was a problem hiding this comment.
Do the anchors hurt anything if they are used with fullmatch? Just thinking in case someone changes what method is used and don't realize the regex is tailored to fullmatch.
Contributor
Author
There was a problem hiding this comment.
I can test. This doesn't affect the public string, just ._regex. Those were not the right anchors away, /A and /Z are more technically correct.
Contributor
Author
There was a problem hiding this comment.
It does seem to be about 1% slower with the anchors. Since the public string VERSION_PATTERN is the same, I think it's fine to change the internal ._regex slightly like this? That's what the _ at the front means, after all. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup before #988 (commit also present there).
[], no need to escape.fullmatch(3.4+) instead ofsearch+ anchors