Skip to content

Fix arbitrary equality intersection preservation in SpecifierSet #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
notatallshaw merged 3 commits into from
Oct 31, 2025
Merged

Fix arbitrary equality intersection preservation in SpecifierSet #951

notatallshaw merged 3 commits into from
Oct 31, 2025

Conversation

@notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Oct 29, 2025 •
edited
Loading

Towards #943

I am reviewing arbitrary equality edge cases, here's an edge case that violates intersection preservation :

>>> list(SpecifierSet("===1.0").filter(["1.0", "1.0.0"]))
['1.0']
>>> list(SpecifierSet("===1.0.0").filter(["1.0", "1.0.0"]))
['1.0.0']
>>> list(SpecifierSet("===1.0,===1.0.0").filter(["1.0", "1.0.0"]))
['1.0']

The last expression is fixed by this PR:

>>> list(SpecifierSet("===1.0,===1.0.0").filter(["1.0", "1.0.0"]))
[]

@notatallshaw notatallshaw force-pushed the fix-arbitrary-equality-symmetry branch from fb2846f to 06ae1be Compare October 29, 2025 00:33
@notatallshaw notatallshaw merged commit b68980b into pypa:main Oct 31, 2025
39 checks passed
@notatallshaw notatallshaw mentioned this pull request Oct 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notatallshaw @henryiii