Skip to content

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented May 12, 2025

python_version only include major and minor version, the current example is kinda misleading

@trim21 trim21 changed the title Update example for python_version Update example for env marker python_version May 12, 2025
@brettcannon
Copy link
Member

python_version only include major and minor version

It actually on purpose and makes sense if you used Python way back in the day. 😅

@trim21
Copy link
Contributor Author

trim21 commented May 12, 2025

python_version only include major and minor version

It actually on purpose and makes sense if you used Python way back in the day. 😅

I'm younger generation of python user, so back then the python_version contains full python version including patch?

@trim21
Copy link
Contributor Author

trim21 commented May 12, 2025

Mostly I mean env = {'python_version': '1.5.4'} is misleading, not python_version>'2'.

python_version>'2' works as expected in package manager I think, but env = {'python_version': '1.5.4'} may mislead someone to write env marker like python_version>'3.11.3'

@brettcannon
Copy link
Member

Mostly I mean env = {'python_version': '1.5.4'} is misleading, not python_version>'2'.

Ah, OK. Can you change your PR to only change that part then? You are right that python_version only has the major and minor version.

@trim21
Copy link
Contributor Author

trim21 commented May 13, 2025

ok

@brettcannon brettcannon merged commit 22e40f5 into pypa:main May 15, 2025
4 checks passed
@brettcannon
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants