tests: do not reload the tags module#1152
Merged
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
add7298 to
f50cd7d
Compare
notatallshaw
approved these changes
Apr 8, 2026
sbidoul
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading the module has bad side effects. One of them is that
tags.pycannot contain exceptions, since they get replaced on reload, causing catching them to fail (see #1150), which can cause running this test first to break things after it. Let's make this a helper function and unit test that instead.Discovered in #1150 using claude-haiku-4.5 in VSCode's copilot.