Skip to content

feat: support positional pattern matching on Version/Specifier #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henryiii merged 1 commit into from
Nov 30, 2025
Merged

feat: support positional pattern matching on Version/Specifier #1004

henryiii merged 1 commit into from
Nov 30, 2025

Conversation

@henryiii
Copy link
Contributor

@henryiii henryiii commented Nov 28, 2025

This adds pattern matching support to Version/Specifier/SpecifierSet. You've always been able to get the components, but now you can get the string that creates one, too. For example:

item = Version("1.2")

match item:
    case Version(version):
        assert version == "1.2"

@henryiii henryiii force-pushed the henryiii/feat/patternmatch branch 3 times, most recently from ea9aa47 to b7c1f65 Compare November 28, 2025 03:07
@henryiii
perf: add __slots__ to Specifiers (pypa#1002)
3716622 
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@henryiii henryiii force-pushed the henryiii/feat/patternmatch branch from b7c1f65 to 3716622 Compare November 30, 2025 05:38
notatallshaw
notatallshaw approved these changes Nov 30, 2025
View reviewed changes
Copy link
Member

@notatallshaw notatallshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henryiii henryiii merged commit 7cafa45 into pypa:main Nov 30, 2025
40 checks passed
@henryiii henryiii deleted the henryiii/feat/patternmatch branch November 30, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notatallshaw notatallshaw notatallshaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii @notatallshaw