perf: add __slots__ to Version #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
approved these changes
Nov 27, 2025
Member
notatallshaw
left a comment
There was a problem hiding this comment.
In pip we already use __slots__ in performance critical classes, it was actually a surprise to see it missing from Version in packaging.
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
fe2dc74 to
f144771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small performance improvement (1.7%), might reduce memory a bit, and could help against typos, like someone trying to assign to the
_versionattribute, which does nothing now.