-
Notifications
You must be signed in to change notification settings - Fork 52
PEP 639 compliance #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 639 compliance #294
Conversation
Keep the redundant Trove classifier for now, until tools such as pip-licenses support PEP 639.
Fixes this build error:
flit_core.config.ConfigError: License classifiers are deprecated in favor of the license expression.
Remove the 'License :: OSI Approved :: MIT License' classifier
dfaea1b to
ff6cbb7
Compare
Since in the end you removed it, maybe that's a sign that this PR is too soon? I'd also recommend submitting a bug report to the upstream build backend asking for this error message to be deleted, since it appears the error message is in fact a bad thing that breaks the ecosystem. |
|
Too soon? I don't know. It's almost exclusively an issue with pip-licenses, which hardly appears to be maintained: it is a tool designed to dump a license list but doesn't support PEP 639 - created more than 5 years ago. |
|
With that said, the error message could indeed be turned into a warning:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Upstream issue: pypa/flit#753. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Gentlebeings, this is neither the PR nor the repo for such discussion. Please, keep the discussion on topic. |
Keep the redundant Trove classifier for now, until tools such as pip-licenses support PEP 639.