Closed
Conversation
ba40575 to
9101651
Compare
c70ee4d to
abf32e3
Compare
b11f56b to
3d461f7
Compare
Signed-off-by: Naveen M K <naveen521kk@gmail.com>
3d461f7 to
cc2e1b0
Compare
This is needed so that the function works even when paths aren't seperated with `\`. Also, this is needed on MSYS2 as it changes `os.sep` to `/` when MSYSTEM variable is defined. Also, fix the test where `os.sep` isn't changed.
8b9b78a to
101de67
Compare
Member
|
Closing as this work appears to be abandoned. Feel free to ping this PR and I can re-open it if needed. |
Contributor
Author
Sorry, just got busy with other things. I'll ping you when I get time to work on these. One thing this PR depends on for the tests to pass is msys2-contrib/cpython-mingw#82 which again became stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
These are from https://github.com/msys2-contrib/cpython-mingw/commits/mingw-v3.9.7/Lib/distutils. I have modified some of them for better logic and removed some unnecessary stuff from them.
This is a draft and built on top of #77
cc @lazka