Conversation
| return ['msvcr120'] | ||
| elif int(msc_ver) >= 1900 and int(msc_ver) < 2000: | ||
| # VS2015 / MSVC 14.0 | ||
| return ['ucrt', 'vcruntime140'] |
There was a problem hiding this comment.
How can I confirm these are the right values to confirm? Have you tested distutils/setuptools with this patch? Does it fix the issue reported in the linked discussion?
You can also do this to
Yes and no. Actually it will introduce another issue. Firstly, However I think this |
|
Thanks for rebasing, where now there are CI tests. Unfortunately, now you can see that the tests fail with this change, so clearly there's more to do. |
|
Looks like we just need to update the tests |
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
I have added test case for The impact should be small once merged. Because the default compiler is MSVC. Mingw is opt-in, and it can't work for years. What will be changed is that when users try to use Mingw, they will get the error of Besides in GitHub codespaces it fails when I use |
|
@jaraco, can you approve for the CI to run? |
|
@njsmith Hi, would you mind reviewing this? Since you originally reviewd |
See pypa/setuptools#2675
After checking the dependencies of those pyd in .whl built by MSVC and python39.dll through
objdump -p xxx.pyd | code -, I personally think both ucrt and vcruntime140 should be specified.