Conversation
0039a79 to
e9eb697
Compare
Avasam
commented
Sep 14, 2024
| ) | ||
|
|
||
| @pytest.mark.skipif( | ||
| not sysconfig.get_platform().startswith("win"), |
Contributor
Author
There was a problem hiding this comment.
Alternatively:
Suggested change
| not sysconfig.get_platform().startswith("win"), | |
| sysconfig.get_platform() not in _msvccompiler._vcvars_names, |
or
Suggested change
| not sysconfig.get_platform().startswith("win"), | |
| get_platform() not in _msvccompiler._vcvars_names, |
But that's starting to look a lot like tests following the implementation
…piler` Actually use the `plat_name` param in `MSVCCompiler.initialize` Added tests
7d0a6d6 to
a0339c1
Compare
jaraco
reviewed
Sep 15, 2024
jaraco
approved these changes
Sep 15, 2024
jaraco
reviewed
Sep 15, 2024
| @@ -0,0 +1 @@ | |||
| Fix cross-platform compilation using ``distutils._msvccompiler.MSVCCompiler`` -- by :user:`saschanaz` and :user:`Avasam` | |||
Member
There was a problem hiding this comment.
Oh, gosh. I'm realizing now that we can't use these news fragments. They refer to issues in this repository, which is merged into Setuptools, so adding them here will cause setuptools to render them as their own issues. I'll just delete it.
Contributor
Author
There was a problem hiding this comment.
Oh right!
Well you could still have newsfragments without issue # if it starts with + (for example: +distutils298.bugfix.rst)
In this case it could refer to the issue I opened on setuptools' repo.
Member
There was a problem hiding this comment.
Good idea. I'll aim to do things like that in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually use the
plat_nameparam inMSVCCompiler.initializeThanks @saschanaz #285 (comment)
Fixes pypa/setuptools#4648 (comment)