Fixed Issue on Windows+MSYS2 with unsafe handling of CC config variable.#144
Merged
Fixed Issue on Windows+MSYS2 with unsafe handling of CC config variable.#144
Conversation
Member
It seems to me you fixed the problem twice, once by putting a conditional on the CC var and again by moving the check outside the scope where it was missing, thereby creating new logic that's no longer relevant. Especially since this logic is not tested, let's limit the change to the minimum suitable. I'll remove the conditional on the CC var. |
This was referenced Jun 13, 2022
This was referenced Jun 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms like Windows in combination with MSYS2 this part of code gets executed but the CC config variable does not exist.
I added a check for if the CC config variable was found and moved the code to the only platform case that requires it.