Add handling for cross-compilation environments.#231
Merged
vsajip merged 1 commit intopypa:masterfrom Oct 7, 2024
Merged
Conversation
This was referenced Sep 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 81.49% 76.95% -4.55%
==========================================
Files 24 24
Lines 8885 8865 -20
Branches 1747 1630 -117
==========================================
- Hits 7241 6822 -419
- Misses 1300 1675 +375
- Partials 344 368 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks for pushing the button to run CI; AFAICT, the test failures are all due to codecov, and the coverage failure is because codecov rejected the upload. Not sure if there's anything I can do to resolve this one at my end... |
Collaborator
|
Don't worry, that Codecov failure will be looked at. Thanks! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling to
_build_shebang()that will unconditionally use the "non-simple" shebang if the current environment is marked as a cross-compilation environment.In cross-compilation environments, the "python interpreter" can be a script that injects environmental modifications. However, these scripts then fail if they're used as a bare shebang, because they're not strictly an executable. The "non-simple" shebang is a workaround for this.
The marker for a cross-compilation environment is the one used by crossenv.
Fixes #230.