fix(action): no need to modify path for extras#2673
Closed
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Member
|
I'm not sure why this had an impact as you mentioned in #2663 (comment), maybe we should add a backend test (meson-python, scikit-build-core, maturin) ?
cibuildwheel/cibuildwheel/venv.py Line 111 in 3c2d596 |
Contributor
Author
|
Should we fix the direct usage, then? |
Contributor
|
Thanks for this henryiii! I think both are a good idea - removing the direct Do we understand why the action change causes an issue with link.exe in meson-python? I don't see how that relates... regardless this solution seems good to me. |
This was referenced Dec 14, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try simpler action. See #2663.