chore: refactor cibuildwheel.utils#2252
Merged
Conversation
Member
Author
|
qemu tests are failing because of:
|
joerick
approved these changes
Jan 27, 2025
Contributor
There was a problem hiding this comment.
Haha I have a local branch with almost exactly the same work on it, did it on Friday morning. No matter. I actually think I like your version better, I also moved some bits to a resources module, but yours moves a few bits out of util (ci, frontend), which makes sense to me.
I think it's worth getting this in relatively quickly, to minimise merge conflict misery.
henryiii
approved these changes
Jan 27, 2025
Contributor
henryiii
left a comment
There was a problem hiding this comment.
Sooner rather than later sounds good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #1873 (comment)
I changed a bit the layout from the comment to split a bit more cibuildwheel.utils
close #1873
fix #1857