chore: add warning when running cibuildwheel with python<3.11#2050
chore: add warning when running cibuildwheel with python<3.11#2050
Conversation
cibuildwheel/__main__.py
Outdated
| python_version = ".".join(map(str, python_version_deprecation[0])) | ||
| msg = ( | ||
| f"cibuildwheel {python_version_deprecation[1]}+ will require Python {python_version}+, " | ||
| "please upgrade your python version." |
There was a problem hiding this comment.
| "please upgrade your python version." | |
| "please upgrade your Python version used to run cibuildwheel." |
There was a problem hiding this comment.
My feeling of this message, even with @henryiii suggestion, is that many people will understand that cibuildwheel will build only python 3.11+ wheels.
But I do not have an idea how to rephrase it. Maybe add longer text in docs and add a link to such doc page in message?
There was a problem hiding this comment.
Maybe add: As always, this does not affect the versions you can target when building wheels. See docs: <link>
?
There was a problem hiding this comment.
I'm not completely sure the commit I just added is the best way to do that but that's the best I could think of.
Having the full matrix of targets just below the sentence "While cibuildwheel itself requires a recent enough python version to run, it can target the following versions to build wheels", I don't think there can be any confusion left.
39b8dd1 to
3fe5b44
Compare
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
towards #2047