Conversation
|
Tests are currently failing because the version of |
91cf8e0 to
2964825
Compare
|
Wow, I can't believe this works so easily! So the idea is that CPython extensions should be able to build without modification for pypy as well? If that's the case, I'd love to just add this to CIBW_BUILD by default and users could get pypy wheels as a bonus - it'd be easy enough to turn them off with CIBW_SKIP if they weren't desired. If the compatibility is good, we could be producing pypy wheels be accident! |
Yes, PyPy support for the C API is now complete (though it's still not as efficient), and
Yes! Sounds good to me :) This is just |
|
Does it make sense to try and build macOS and/or windows wheels as well ? |
Yes, it's on my TODO list. But for Windows, I was waiting for a resolution of the Windows-installation choice. And for macOS, I need to dive into the versioning of macOS (cfr. #156), since for PyPy3 the download page reads "(High Sierra >= 10.13, not for Sierra and below)". In either case, it won't be as simple as replacing a Docker image, since I can't see |
b85bd00 to
1bc35d2
Compare
|
PyPy on Windows now also works! :) Two remarks:
|
…ewer version of manylinux2010-pypy_x86_64 image
…yPy executable `python` symlinks outside of installation directory
…ow that it supports 7.3.0
…pp36 for C++17) on Windows
|
Getting close to finishing this! :-) The pypy/manylinux PR with |
But if we pin virtualenv bellow 20 then it works. And if they finish then minor bugfix can be released. |
|
I'm not waiting, take your time and do it right. I already released the blog post with a little caveat about cibuildwheel. It didn;t get alot of traction anyway, I guess I shouldn't post on a Sunday. |
README.md
Outdated
| | PyPy 2.7 v7.3.0 | ✅² | | ✅ | ✅ | | | ||
| | PyPy 3.6 v7.3.0 | ✅² | | ✅ | ✅ | | |
There was a problem hiding this comment.
Good catch, thanks!
joerick
left a comment
There was a problem hiding this comment.
Congratulations on this monumental effort @YannickJadoul! I have a few comments, they are inline.
|
@joerick, I addressed the few new remarks, I think :-) |
|
Woohoooooo, merged! Thanks, everyone! :-) |
There's probably still a lot to discuss on choosing defaults, option names, build tag names, ... but we can already give this a go and see if we can get the technical part working :)
Cfr. #143