Skip to content

test: cover config settings build paths#992

Merged
gaborbernat merged 4 commits into
pypa:mainfrom
terminalchai:test/config-settings-coverage
Apr 9, 2026
Merged

test: cover config settings build paths#992
gaborbernat merged 4 commits into
pypa:mainfrom
terminalchai:test/config-settings-coverage

Conversation

@terminalchai

Copy link
Copy Markdown
Contributor

Summary

  • add direct unit coverage for build_package() forwarding config_settings into _build()
  • add unit coverage for build_package_via_sdist() forwarding config_settings through both the sdist and wheel build steps
  • keep the assertions focused on the missing forwarding paths described in No test covering config_settings argument to build #89

Testing

  • python -m tox -e py311 -- tests/test_main.py -k "config_settings"
  • python -m tox -e fix (currently fails while creating the upstream docstrfmt pre-commit environment because it requires sphinx>=9.1, which is unavailable on the local Python used by that env)

Closes #89

@henryiii

Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

terminalchai and others added 3 commits April 9, 2026 12:47
Parallel xdist workers can create __pycache__ in test package
directories while the sdist is being built, causing flit to
include them despite the exclude pattern.
@gaborbernat gaborbernat force-pushed the test/config-settings-coverage branch from b0e9251 to 7c942ce Compare April 9, 2026 19:49
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@gaborbernat gaborbernat merged commit 487cf15 into pypa:main Apr 9, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No test covering config_settings argument to build

3 participants