Conversation
Contributor
Author
|
It looks like the only test failures are the same ones that are currently already failing on HEAD.
|
henryiii
reviewed
Sep 4, 2024
Skip the tests that need uv when uv is not installed. This makes it easier for Linux distros that package build to avoid a build-time dependency on uv. Update tests/test_env.py
2153524 to
980d04b
Compare
henryiii
approved these changes
Sep 5, 2024
Member
|
There’s two ways that we detect the presence of uv and this only checks one. The tests might be skipped even if uv is present (e.g. if it’s on the PYTHONPATH but its executable isn’t on PATH). |
Contributor
|
Yes, we should add the other way to the check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the tests that need uv when uv is not installed. This makes it easier for Linux distros that package build to avoid a build-time dependency on uv.