perf: avoid compiling unused bytecode#752
Merged
Conversation
Contributor
Author
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
33d987a to
244e768
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
layday
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling bytecode is supposed to make usage more consistent for interaction. But it compiles everything, which isn't required for a single use non-interactive temporary environment. We can potentially save a bit of time this way.
This will need to be skipped for the uv backend in #751, since uv defaults to not compiling bytecode, and instead requires a flag to do so (most recent version). But flags aren't identical anyway.