You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would prefer if the env var was injected with pytest-env so that the tests behave identically when run directly with pytest. Can do that in a follow-up if you'd prefer not to spend more time on this.
I would prefer if the env var was injected with pytest-env so that the tests behave identically when run directly with pytest. Can do that in a follow-up if you'd prefer not to spend more time on this. You're welcome to push to my branch to include in this PR.
Please do. Since there's no prior art in this repo for it, I'd prefer if a maintainer took it on so it ends up in the preferred place with the preferred style.
I see some tests failing, and the failures don't appear to me to be related to the change. Please let me know if you need anything from me to handle that situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failures when PYTHONWARNDEFAULTENCODING=1. Fixes #577.