Skip to content

Sort compressed tag sets when rewriting wheel filename#584

Merged
mayeut merged 4 commits intopypa:mainfrom
di:fix/583
May 17, 2025
Merged

Sort compressed tag sets when rewriting wheel filename#584
mayeut merged 4 commits intopypa:mainfrom
di:fix/583

Conversation

@di
Copy link
Copy Markdown
Member

@di di commented May 16, 2025

Fixes #583.

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (8628e84) to head (13b4911).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          21       21           
  Lines        1760     1760           
  Branches      332      332           
=======================================
  Hits         1633     1633           
  Misses         77       77           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@di
Copy link
Copy Markdown
Member Author

di commented May 16, 2025

Not sure I understand why this would cause coverage to decrease.

@oraluben
Copy link
Copy Markdown
Contributor

fyi: the 3.9 failure could be workarounded by: 7993e1d

@auvipy auvipy requested a review from mayeut May 17, 2025 08:49
@mayeut
Copy link
Copy Markdown
Member

mayeut commented May 17, 2025

Not sure I understand why this would cause coverage to decrease.

There's no sync between jobs (and CI services) so the report is only valid once all jobs have run.

@mayeut mayeut merged commit 704d119 into pypa:main May 17, 2025
14 checks passed
@mayeut
Copy link
Copy Markdown
Member

mayeut commented May 17, 2025

Thanks

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jun 3, 2025

@di @mayeut @woodruffw FYI, this might've potentially cascaded into digital signature verification failures: pypa/gh-action-pypi-publish#365.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compressed tag sets are not sorted when rewriting wheel filename.

4 participants